Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Fix Flowable + Single elementAt and elementAtOrError operators on empty sources #4681

Merged
merged 1 commit into from
Oct 7, 2016
Merged

2.x: Fix Flowable + Single elementAt and elementAtOrError operators on empty sources #4681

merged 1 commit into from
Oct 7, 2016

Conversation

vanniktech
Copy link
Collaborator

This will fix #4680

  • elementAtOrError(1) on an empty source just leaves the new Single hanging without signalling onError()
  • elementAt(1) on an empty source just leaves the Maybe hanging without signalling onComplete()
  • I also noticed that elementAt() with a default value on an empty source did not work either.

@akarnokd akarnokd added the Bug label Oct 7, 2016
@akarnokd akarnokd added this to the 2.0 RC5 milestone Oct 7, 2016
@codecov-io
Copy link

codecov-io commented Oct 7, 2016 •
edited
Loading

Current coverage is 82.15% (diff: 0.00%)

Merging #4681 into 2.x will increase coverage by 0.17%

@@                2.x      #4681   diff @@
==========================================
  Files           565        565          
  Lines         37426      37426          
  Methods           0          0          
  Messages          0          0          
  Branches       5746       5746          
==========================================
+ Hits          30682      30749    +67   
+ Misses         4666       4608    -58   
+ Partials       2078       2069     -9

Powered by Codecov. Last update 27e8dad...5e3ce8e

@akarnokd
Copy link
Member

akarnokd commented Oct 7, 2016

You may have to check the build and restart it a few times if it fails with jacocoTestReport.

@akarnokd akarnokd merged commit e654e9b into ReactiveX:2.x Oct 7, 2016
@akarnokd akarnokd mentioned this pull request Oct 7, 2016
Closed
@vanniktech vanniktech deleted the elemen_at branch October 7, 2016 09:54
@akarnokd akarnokd mentioned this pull request Oct 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarnokd akarnokd akarnokd approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.0 RC5
Development

Successfully merging this pull request may close these issues.

2.x: ElementAt Operators in Observable and Flowable don't behave correctly on empty sources
3 participants
@vanniktech @codecov-io @akarnokd